Edit type hierarchy relationships in the Type Editor - #1876
Closed
PaulHax wants to merge 5 commits into
Closed
Conversation
Collaborator
Author
|
Superseded by #1877, which uses the type-hierarchy-editor branch in Kitware/dive instead of the fork. The commits and PR description are unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit type hierarchy relationships in the Type Editor
DIVE can display and import type hierarchies, but users currently have to edit configuration JSON
to create or change the relationships.
This PR adds Parent Type to the existing Type Editor opened from a Type List row's pencil. There
is no separate hierarchy mode: types remain ordinary types, and a type may optionally have a parent.
Parent-only edits change the dataset hierarchy without rewriting stored annotation confidence
pairs. A dataset with no parent edges keeps its existing flat behavior.
Changes
missing parents through + Types in Type Settings.
the complete edit before applying any changes.
and Saved Styles editors.
Validation
1cfa6e0a: 400 server tests, 1,346 client/Desktop tests,server and client lint, Web build, and Electron AppImage build.
Manual tests
Test data is available from
PaulHax/dive-devkit.
From a workspace containing
dive/anddive-devkit/:Create and remove a hierarchy edge
tunain the Type List, click its pencil, and selectfishas Parent Type.tuna, clear Parent Type, save the editor and dataset, and reload again.Verify:
tunaappears beneathfishafter the first save and reload.fish,tuna, anddolphinannotations and confidence values are unchanged.fishandtunaremain available after the final edge is removed.Reparent and validate atomically
bluefin-tunafrom parenttunato parentred-snapper.bluefin-tuna,tuna, andfishconfidence values, then restore its original parent.
fishand selectbluefin-tunaas its parent.Verify:
Rename and reparent together
unobserved-speciestype.fishas its new parent in the same editor session.Verify:
fish.Delete unused hierarchy headings
unobserved-genus.eukaryota.bluefin-tuna.Verify:
unobserved-speciesmoves directly beneathvertebrata.animaliabecomes top-level aftereukaryotais removed.Parent search
seriola_rivolianaand search Parent Type by both prefix and substring.Verify:
Multicamera persistence
Verify:
This is a follow-up to
Render hierarchical types as a tree.